impr(polyglot): Add new structure (wordsetMap) to PolyglotWordset to get words from any language by uniform distribution (@IliyaZinoviev) by IliyaZinoviev · Pull Request #7440 · monkeytypegame/monkeytype

IliyaZinoviev · 2026-01-24T10:55:39Z

Add uniform distribution to polyglot

Motivation

During polyglot using, I mentioned that words from language with huge dictionaries are met always, but words from small one - never (at least from a user experience perspective, it looks like this). My PR solves this issue. And now each language is consumed per test as much as any other.

Description

Changed:

PolyglotWordset class
places in files where PolyglotWordset is used:
- words-generator.ts
- funbox-functions.ts .

Checks

Closes #

@IliyaZinoviev

…t words from any language by uniform distribution (@IliyaZinoviev)

Copilot

Pull request overview

Adjusts polyglot word generation so languages are sampled (approximately) uniformly, rather than being dominated by languages with larger dictionaries.

Changes:

Refactors PolyglotWordset to store per-language Wordsets (wordsMap) and pick a language uniformly per generated word.
Updates word generation logic to use PolyglotWordset.currentLanguage instead of per-word language lookups.
Small control-flow cleanup in word list retrieval / funbox wordset assignment.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
frontend/src/ts/test/words-generator.ts	Switches polyglot language detection to `currentLanguage`; minor cleanup around word list returns and funbox wordset assignment.
frontend/src/ts/test/funbox/funbox-functions.ts	Reworks `PolyglotWordset` internals to use `wordsMap` and uniform language selection.

frontend/src/ts/test/funbox/funbox-functions.ts

IliyaZinoviev · 2026-03-04T19:07:15Z

For now, I am not sure where to store strView as a separate function or as a static method of PolyglotWordset.

@IliyaZinoviev

- Add strView to not duplicate data. (@IliyaZinoviev)

Miodec · 2026-03-09T12:58:32Z

Whats strView doing? Can you add some documentation?

Miodec · 2026-03-15T19:01:32Z

Is it possible to change the approach? The string view thing seems a bit over engineered in my opinion?

@IliyaZinoviev

…y string objects. (@IliyaZinoviev)

Miodec · 2026-03-17T09:58:43Z

@IliyaZinoviev I made a small (kinda) change where now we connect the wordset word and language together, instead of grabbing it from the class - that way it should be impossible for them to get out of sync in anyway. What do you think?

IliyaZinoviev

I am OK with your commit. But I am not sure that remove of currentLanguage get method makes code better. Maybe it's improvement of next iteration.

IliyaZinoviev · 2026-03-19T14:01:52Z

frontend/src/ts/test/funbox/funbox-functions.ts

    this.wordsetMap = wordsetMap;
    this.resetIndexes();
    this.length = words.length;
-    this.currLang = this.langs[0] as Language;


Via WordsetPick, mutable state of PolyglotWordset (currentLanguage) was exterminated, especially its incorrect value on PolyglotWordset initialization (this.currLang = this.langs[0] as Language;). But to achieve it, Wordset class was extended with WordsetPick which included polyglot-specific property (language).

I don't see case when this.currLang becomes unsynchronized.

this.currLang can be optional and then it can be checked on Language value in get currentLanguage() to exclude unexpected undefined value in client code.

IliyaZinoviev · 2026-03-19T14:03:25Z

frontend/src/ts/test/funbox/funbox-functions.ts

  }

-  private uniformLang(): Language {
+  private pickLang(): Language {


Now, mnemonic name is gone so we need docs to highlight uniform distribution inside this method

IliyaZinoviev · 2026-03-19T14:59:39Z

frontend/src/ts/test/words-generator.ts

  randomWord = randomWord.replace(/ +/gm, " ");
  randomWord = randomWord.replace(/(^ )|( $)/gm, "");
-  randomWord = applyLazyModeToWord(randomWord, currentLanguage);
+  randomWord = applyLazyModeToWord(randomWord, currentLanguage, pick.language);


Why is currentLanguage passed as param to applyLazyModeToWord, but currentWordset isn't? But both of them is kinda global in words-generator.ts:

let currentWordset: Wordset | null = null; let currentLanguage: LanguageObject | null = null;

My idea is to update currentLanguage from words-generator.ts on each new word from currentWordset.

PS. It's just thoughts.

IliyaZinoviev · 2026-03-19T15:01:28Z

frontend/src/ts/test/words-generator.ts

+function applyLazyModeToWord(
+  word: string,
+  language: LanguageObject,
+  polyglotLang?: Language,


If Wordset class's methods return WordsetPick then case theoretically exists when some child Wordset class returns Language. So maybe not to name it as polyglotLang at all, just wordsetLang or something?

IliyaZinoviev · 2026-03-19T15:23:44Z

I can offer to try to make this.currLang optional and replace PolyglotWordset.languageProperties Map<Language, JSONData.LanguageProperties> on PolyglotWordset.languageMap: <Language, LanguageObject>.

I don't have any related to polyglot offers.

monkeytypegeorge added the frontend User interface or web stuff label Jan 24, 2026

IliyaZinoviev force-pushed the feature/balanced-polyglot-v3 branch 2 times, most recently from 2d5e9ad to ed49d47 Compare January 24, 2026 14:18

impr(polyglot): Add new structure (wordsMap) to PolyglotWordset to ge…

52be7ba

…t words from any language by uniform distribution (@IliyaZinoviev)

IliyaZinoviev force-pushed the feature/balanced-polyglot-v3 branch from ed49d47 to 52be7ba Compare January 27, 2026 06:56

Miodec requested a review from Copilot February 27, 2026 14:01

github-actions bot added the waiting for review Pull requests that require a review before continuing label Feb 27, 2026

Copilot started reviewing on behalf of Miodec February 27, 2026 14:02 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

frontend/src/ts/test/funbox/funbox-functions.ts Outdated Show resolved Hide resolved

frontend/src/ts/test/funbox/funbox-functions.ts Outdated Show resolved Hide resolved

Miodec added waiting for update Pull requests or issues that require changes/comments before continuing and removed waiting for review Pull requests that require a review before continuing labels Feb 28, 2026

github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Mar 4, 2026

impr(polyglot): Small refactoring in Wordset classes. (@IliyaZinoviev)

5f47b5d

IliyaZinoviev force-pushed the feature/balanced-polyglot-v3 branch from 6d1d342 to fcdb490 Compare March 4, 2026 18:42

IliyaZinoviev marked this pull request as draft March 4, 2026 18:52

IliyaZinoviev marked this pull request as ready for review March 4, 2026 18:54

github-actions bot added the waiting for review Pull requests that require a review before continuing label Mar 4, 2026

IliyaZinoviev marked this pull request as draft March 5, 2026 06:04

github-actions bot removed the waiting for review Pull requests that require a review before continuing label Mar 5, 2026

impr(polyglot): Populate PolyglotWordset.words.

f1461fd

- Add strView to not duplicate data. (@IliyaZinoviev)

IliyaZinoviev force-pushed the feature/balanced-polyglot-v3 branch from fcdb490 to f1461fd Compare March 5, 2026 06:53

IliyaZinoviev marked this pull request as ready for review March 5, 2026 07:02

github-actions bot added the waiting for review Pull requests that require a review before continuing label Mar 5, 2026

Merge branch 'master' into feature/balanced-polyglot-v3

b489839

Miodec added waiting for update Pull requests or issues that require changes/comments before continuing and removed waiting for review Pull requests that require a review before continuing labels Mar 9, 2026

impr(polyglot): Add docs for strView. (@IliyaZinoviev)

7c0fe60

github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Mar 9, 2026

Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Mar 15, 2026

impr(polyglot): Replace strView on .slice method cause it doesn't cop…

6b15ccb

…y string objects. (@IliyaZinoviev)

github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Mar 16, 2026

connect wordset word and language together so they dont go out of sync

e2708c8

Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Mar 17, 2026

This comment was marked as outdated.

Sign in to view

github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Mar 19, 2026

IliyaZinoviev commented Mar 19, 2026

View reviewed changes

Uh oh!

Conversation

IliyaZinoviev commented Jan 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Add uniform distribution to polyglot

Motivation

Description

Checks

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

IliyaZinoviev commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Miodec commented Mar 9, 2026

Uh oh!

Miodec commented Mar 15, 2026

Uh oh!

Miodec commented Mar 17, 2026

Uh oh!

This comment was marked as outdated.

IliyaZinoviev left a comment

Choose a reason for hiding this comment

Uh oh!

IliyaZinoviev Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

IliyaZinoviev Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

IliyaZinoviev Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

IliyaZinoviev Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

IliyaZinoviev commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

IliyaZinoviev commented Jan 24, 2026 •

edited

Loading

IliyaZinoviev commented Mar 4, 2026 •

edited

Loading

IliyaZinoviev commented Mar 19, 2026 •

edited

Loading